Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: added missing images via developer.wp.org site #53051

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Conversation

bph
Copy link
Contributor

@bph bph commented Jul 27, 2023

Follow up to #52955
Fix for #53047

What?

linked missing images

Why?

It's better with illustrations
relative references didn't work.

How?

Uploaded to the developer.wordpress.org site media library and added the absolute URL to the Markdown of the page.
and deleted image uploaded into the repo's /assets folder

Testing Instructions

Doc only, use View File link of the PR.

@bph bph changed the title added missing images via developer.wp.org site Docs: added missing images via developer.wp.org site Jul 27, 2023
@bph bph changed the title Docs: added missing images via developer.wp.org site WIP:Docs: added missing images via developer.wp.org site Jul 27, 2023
@ndiego ndiego added the [Type] Developer Documentation Documentation for developers label Jul 27, 2023
Copy link
Member

@ndiego ndiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @bph for fixing this. Next, I need to update the documentation guidelines for image URLs 😅

@bph bph changed the title WIP:Docs: added missing images via developer.wp.org site Docs: added missing images via developer.wp.org site Jul 27, 2023
@github-actions
Copy link

Flaky tests detected in 8a03b76.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5682513660
📝 Reported issues:

@bph bph merged commit a96a1ff into trunk Jul 27, 2023
50 checks passed
@bph bph deleted the docs/gb-release-images branch July 27, 2023 16:13
@github-actions github-actions bot added this to the Gutenberg 16.4 milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants